Hi Sakari,
THank you for the review.
On Mon, Sep 14, 2020 at 7:54 AM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> Thanks for the patchset.
>
> On Sun, Sep 13, 2020 at 07:42:45PM +0100, Lad Prabhakar wrote:
> > Parse endpoint properties using v4l2_fwnode_endpoint_alloc_parse()
> > to determine bus-type and store it locally in priv data.
> >
> > Also for backward compatibility with the existing DT where bus-type
> > isnt specified fallback to V4L2_MBUS_PARALLEL.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> > drivers/media/i2c/ov772x.c | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> > index 2cc6a678069a..551082aa7026 100644
> > --- a/drivers/media/i2c/ov772x.c
> > +++ b/drivers/media/i2c/ov772x.c
> > @@ -31,6 +31,7 @@
> > #include <media/v4l2-ctrls.h>
> > #include <media/v4l2-device.h>
> > #include <media/v4l2-event.h>
> > +#include <media/v4l2-fwnode.h>
> > #include <media/v4l2-image-sizes.h>
> > #include <media/v4l2-subdev.h>
> >
> > @@ -434,6 +435,7 @@ struct ov772x_priv {
> > #ifdef CONFIG_MEDIA_CONTROLLER
> > struct media_pad pad;
> > #endif
> > + enum v4l2_mbus_type bus_type;
> > };
> >
> > /*
> > @@ -1354,6 +1356,8 @@ static const struct v4l2_subdev_ops ov772x_subdev_ops = {
> >
> > static int ov772x_probe(struct i2c_client *client)
> > {
> > + struct v4l2_fwnode_endpoint bus_cfg = { .bus_type = 0 };
> > + struct fwnode_handle *ep;
> > struct ov772x_priv *priv;
> > int ret;
> > static const struct regmap_config ov772x_regmap_config = {
> > @@ -1415,6 +1419,26 @@ static int ov772x_probe(struct i2c_client *client)
> > goto error_clk_put;
> > }
> >
> > + ep = fwnode_graph_get_next_endpoint(dev_fwnode(&client->dev),
> > + NULL);
> > + if (!ep) {
> > + dev_err(&client->dev, "endpoint node not found\n");
> > + ret = -EINVAL;
> > + goto error_clk_put;
> > + }
> > +
> > + bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
> > + ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
> > + priv->bus_type = bus_cfg.bus_type;
> > + v4l2_fwnode_endpoint_free(&bus_cfg);
> > + if (ret) {
> > + /* For backward compatibility with the existing DT where
> > + * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL
>
> "isn't", "fall back", and a period, please.
>
Will fix that.
> > + */
> > + priv->bus_type = V4L2_MBUS_PARALLEL;
> > + dev_notice(&client->dev, "Falling back to V4L2_MBUS_PARALLEL mode\n");
>
> I'd just use dev_dbg().
>
OK will switch to dev_dbg()
Cheers,
Prabhakar
