Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Thursday, September 10, 2020 10:11 PM
>
> Hi Shimoda-san,
>
> On Wed, Sep 9, 2020 at 3:13 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > To support other register layout in the future, add register pointers
> > of control_regs and status_regs into struct cpg_mssr_priv. After that,
> > we can remove unused macros like MSTPSR(). No behavior changes.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/clk/renesas/renesas-cpg-mssr.c
> > +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
>
> > @@ -137,6 +130,8 @@ struct cpg_mssr_priv {
> > unsigned int last_dt_core_clk;
> >
> > struct raw_notifier_head notifiers;
> > + const u16 *status_regs;
> > + const u16 *control_regs;
>
> Please add new fields to the struct's kerneldoc comments above.
Oops. I'll add such comments.
> Note that you need to use a similar dispatching for the Software Reset
> and Software Reset Clearing Registers, as their offsets differ from
> previous SoCs.
Indeed. I'll add these pointers.
> The reset looks good to me, thanks!
Thank you for your review!
Best regards,
Yoshihiro Shimoda
