Hi Geert-san, > From: Geert Uytterhoeven, Sent: Thursday, September 10, 2020 10:07 PM > > On Thu, Sep 10, 2020 at 3:06 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Wed, Sep 9, 2020 at 3:13 PM Yoshihiro Shimoda > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > > Geert suggested defining multiple registers layout variants using > > > an enum [1] to support further devices like R-Car V3U. So, use enum > > > clk_reg_layout instead of a boolean .stbyctrl flag. No behavior change. > > > > > > [1] > > > https://lore.kernel.org/linux-renesas-soc/CAMuHMdVAgN69p9FFnQdO4iHk2CHkeNaVui2Q-FOY6_BFVjQ-Nw@xxxxxxxxxxxxxx/ > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > > > > --- a/drivers/clk/renesas/renesas-cpg-mssr.h > > > +++ b/drivers/clk/renesas/renesas-cpg-mssr.h > > > > > @@ -130,7 +135,7 @@ struct cpg_mssr_info { > > > unsigned int num_core_clks; > > > unsigned int last_dt_core_clk; > > > unsigned int num_total_core_clks; > > > - bool stbyctrl; > > > + enum clk_reg_layout reg_layout; > > > > Seems like you forgot to update the struct's kerneldoc for this rename? Oops. I'll update it. > With that fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thank you for your review! Best regards, Yoshihiro Shimoda
