From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Date: Wed, 9 Sep 2020 14:43:14 +0900 > Since the micrel phy driver calls phy_init_hw() as a workaround, > the commit 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() > in phy_init_hw()") disables the interrupt unexpectedly. So, > call phy_disable_interrupts() in phy_attach_direct() instead. > Otherwise, the phy cannot link up after the ethernet cable was > disconnected. > > Note that other drivers (like at803x.c) also calls phy_init_hw(). > So, perhaps, the driver caused a similar issue too. > > Fixes: 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() in phy_init_hw()") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > --- > Changes from v1: > - Fix build failure. I used two PCs: PC 1) for testing, PC 2) for > submitting patches. I tested on the PC 1. But, after that, I wrote > a patch on the PC2 again, and it seemed I didn't do a compile... > Today, I got some emails from kernel test bot. So, I realized > I had submitted an awful patch. To avoid such failure, I'll use > one PC only from now on. > Applied and queued up for -stable, thanks.