On Wed, Sep 09, 2020 at 04:18:56AM +0000, Yoshihiro Shimoda wrote:
> Hi David,
>
> > From: David Miller, Sent: Wednesday, September 9, 2020 12:25 PM
> >
> > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > Date: Wed, 9 Sep 2020 08:55:38 +0900
> >
> > > Changes from v1:
> > > - Fix build error.
> >
> > When such a fundamental build failure is fixed (it could never have
> > built for anyone, even you), I want it explained why this happened
> > and how this was functionally tested if it did not even compile.
>
> I'm sorry about this. I used two PCs now:
> PC 1 = for testing at local
> PC 2 = for submitting patches at remote (because corporate network situation)
>
> I tested on the PC 1.
> But, after that, I modified the code on the PC 2 again. And, it seemed
> I didn't do a compile.
This sort of split setup is always a bad idea. Always do the git
format-patch on PC 1 and somehow get the patch files off it, and use
PC 2 only for git send-email, never any development work. That way you
will avoid issues like this.
Andrew
