From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Date: Tue, 8 Sep 2020 20:27:20 +0900 > @@ -1423,6 +1419,10 @@ int phy_attach_direct(struct net_device *dev, struct phy_device *phydev, > if (err) > goto error; > > + ret = phy_disable_interrupts(phydev); > + if (ret) > + return ret; > + How did you test this? I am very serious. There is no 'ret' variable in this function, you do not add one, and therefore this does not even compile. If you are patching against a different tree than the networking GIT tree, that is a major mistake as well. That also is why it is very important to specify the destination GIT tree in your subject line such as "[PATCH net]" or "[PATCH net-next]". Thank you.
