Hi Shimoda-san, On Mon, Sep 7, 2020 at 11:20 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > Add device tree bindings documentation for Renesas R-Car V3U > Falcon CPU and BreakOut boards. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > @@ -283,6 +283,9 @@ properties: > > - description: R-Car V3U (R8A779A0) > items: > + - enum: > + - renesas,falcon-cpu # Falcon CPU board (RTP0RC779A0CPB0010S) > + - renesas,falcon-breakout # Falcon BreakOut board (RTP0RC779A0BOB0010S) > - const: renesas,r8a779a0 How is this intended to be used? The above means its users should declare either compatible = "renesas,falcon-cpu", "renesas,r8a779a0"; or compatible = "renesas,falcon-breakout", "renesas,r8a779a0"; However, falcon-cpu.dtsi has just compatible = "renesas,falcon-cpu"; Who will use "renesas,falcon-breakout"? > > - description: RZ/N1D (R9A06G032) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds