Hello, On Wed, Aug 26, 2020 at 06:58:50AM +0000, Biju Das wrote: > > Subject: Re: [PATCH v2 1/3] dt-bindings: display: bridge: lvds-codec: > > Document vcc-supply property > > > > On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > > > Document optional vcc-supply property that may be used as VCC source. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > --- > > > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > > > --- > > > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > index 68951d56ebba..3248be31eceb 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > @@ -79,6 +79,9 @@ properties: > > > The GPIO used to control the power down line of this device. > > > maxItems: 1 > > > > > > + vcc-supply: > > > + maxItems: 1 > > > > Probably should be 'power-supply' to align with the 'simple' panels. > > That's also to signify there's only 1 supply. Using 'vcc' would encourage > > adding 'vdd-supply', 'vddio-supply', etc. A second supply I'll NAK because at > > that point it's not a simple bridge with no configuration (it's arguably already > > there). > > Yes, I am ok with 'power-supply', since LVDS CODEC driver is generic > and also to align with terminology used in generic 'simple' panels. > > In our case this Receiver converts LVDS signals to RGB signals and fed > this signal to simple panel. > On the receiver part, We need to supply power to TTL output, PLL and > LVDS input. It all derived from the single power source. > > Laurent, Please share you opinion on this. Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> That is, I think it's a good idea to rename it, and I agree with Rob about not adding a second supply. I've applied the modified patch to my tree, and will send a pull request this week. -- Regards, Laurent Pinchart
