Re: [PATCH v2 2/3] soc: renesas: align driver description title

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Mon, Aug 17, 2020 at 6:51 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> Now, Renesas SoC drivers are under menu,
> but current description are not aligned.
> This patch align these.
>
>         - R-Car H2 System Controller support                                                                    │ │
>         - R-Car M2-W/N System Controller support                                                                │ │
>         - R-Car V2H System Controller support                                                                   │ │
>         - R-Car E2 System Controller support                                                                    │ │
>         - R-Car H3 System Controller support                                                                    │ │
>         - R-Car M3-W System Controller support                                                                  │ │
>         - R-Car M3-W+ System Controller support                                                                 │ │
>         - R-Car M3-N System Controller support                                                                  │ │
>
>         + System Controller support for R-Car H2                                                                │ │
>         + System Controller support for R-Car M2-W/N                                                            │ │
>         + System Controller support for R-Car V2H                                                               │ │
>         + System Controller support for R-Car E2                                                                │ │
>         + System Controller support for R-Car H3                                                                │ │
>         + System Controller support for R-Car M3-W                                                              │ │
>         + System Controller support for R-Car M3-W+                                                             │ │
>         + System Controller support for R-Car M3-N                                                              │ │
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -276,97 +276,97 @@ endif # ARM64
>
>  # SoC
>  config SYSC_R8A7742
> -       bool "RZ/G1H System Controller support" if COMPILE_TEST
> +       bool "System Controller support for RZ/G1H" if COMPILE_TEST
>         select SYSC_RCAR

[...]

>  config SYSC_R8A77995
> -       bool "R-Car D3 System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Car D3" if COMPILE_TEST
>         select SYSC_RCAR
>
>  # Family
>  config RST_RCAR
> -       bool "R-Car Reset Controller support" if COMPILE_TEST
> +       bool "Reset  Controller support for R-Car" if COMPILE_TEST

This one looks a bit strange, in between SoC-specific and family-specific
System Controller support.

It could be moved up (breaking the separation between SoC-specific
and family-specific options), or down (breaking alphabetical sort order).
Any other options?

>
>  config SYSC_RCAR
> -       bool "R-Car System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Car" if COMPILE_TEST
>
>  config SYSC_RMOBILE
> -       bool "R-Mobile System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Mobile" if COMPILE_TEST
>
>  endif # SOC_RENESAS

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux