[PATCH 2/4] media: i2c: max9286: Get format from remote ends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The MAX9286 chip does not allow any modification to the image stream
format it de-serializes from the GMSL bus to its MIPI CSI-2 output
interface.

For this reason, when the format is queried from on any of the MAX9286
pads, get the remote subdevice format and return it.

Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
---
 drivers/media/i2c/max9286.c | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 7c292f2e2704..e6a70dbd27df 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -742,8 +742,10 @@ static int max9286_get_fmt(struct v4l2_subdev *sd,
 			   struct v4l2_subdev_format *format)
 {
 	struct max9286_priv *priv = sd_to_max9286(sd);
-	struct v4l2_mbus_framefmt *cfg_fmt;
+	struct v4l2_subdev_format remote_fmt = {};
+	struct device *dev = &priv->client->dev;
 	unsigned int pad = format->pad;
+	int ret;
 
 	/*
 	 * Multiplexed Stream Support: Support link validation by returning the
@@ -754,12 +756,26 @@ static int max9286_get_fmt(struct v4l2_subdev *sd,
 	if (pad == MAX9286_SRC_PAD)
 		pad = __ffs(priv->bound_sources);
 
-	cfg_fmt = max9286_get_pad_format(priv, cfg, pad, format->which);
-	if (!cfg_fmt)
-		return -EINVAL;
+	if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
+		mutex_lock(&priv->mutex);
+		format->format = *v4l2_subdev_get_try_format(&priv->sd,
+							     cfg, pad);
+		mutex_unlock(&priv->mutex);
+
+		return 0;
+	}
+
+	remote_fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
+	remote_fmt.pad = 0;
+	ret = v4l2_subdev_call(priv->sources[pad].sd, pad, get_fmt, NULL,
+			       &remote_fmt);
+	if (ret) {
+		dev_err(dev, "Unable get format on source %d\n", pad);
+		return ret;
+	}
 
 	mutex_lock(&priv->mutex);
-	format->format = *cfg_fmt;
+	format->format = remote_fmt.format;
 	mutex_unlock(&priv->mutex);
 
 	return 0;
-- 
2.27.0




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux