Hi Prabhakar, On Mon, Aug 10, 2020 at 11:22 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx> > > The RZ/G2H (R8A774E1) has 6 VSP instances. > > Based on the work done for r8a7795 SoC. > > Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > @@ -2374,6 +2374,72 @@ > status = "disabled"; > }; > > + vspbc: vsp@fe920000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfe920000 0 0x8000>; > + interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 624>; > + power-domains = <&sysc R8A774E1_PD_A3VP>; > + resets = <&cpg 624>; > + > + renesas,fcp = <&fcpvb1>; > + }; > + > + vspbd: vsp@fe960000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfe960000 0 0x8000>; > + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 626>; > + power-domains = <&sysc R8A774E1_PD_A3VP>; > + resets = <&cpg 626>; > + > + renesas,fcp = <&fcpvb1>; According to "FCPVB0 (for VSPBD): H' FE96_F000", this should be renesas,fcp = <&fcpvb0>; ? If you agree, I can fix that while applying. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v5.10. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds