Hi Tomi,
On Thu, Aug 06, 2020 at 10:46:43AM +0300, Tomi Valkeinen wrote:
> On 06/08/2020 05:17, Laurent Pinchart wrote:
> > The device minor number is needed to access the debugfs directory
> > corresponding to the device. Make it available to users through a
> > get_minor() method on the Card object.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > kms++/inc/kms++/card.h | 3 +++
> > kms++/src/card.cpp | 11 +++++++++++
> > py/pykms/pykmsbase.cpp | 1 +
> > 3 files changed, 15 insertions(+)
> >
> > diff --git a/kms++/inc/kms++/card.h b/kms++/inc/kms++/card.h
> > index 5c1cf7cfcedc..0a11747f7985 100644
> > --- a/kms++/inc/kms++/card.h
> > +++ b/kms++/inc/kms++/card.h
> > @@ -35,6 +35,7 @@ public:
> > Card& operator=(const Card& other) = delete;
> >
> > int fd() const { return m_fd; }
> > + unsigned int dev_minor() const { return m_minor; }
> >
> > void drop_master();
> >
> > @@ -84,7 +85,9 @@ private:
> > std::vector<Framebuffer*> m_framebuffers;
> >
> > int m_fd;
> > + unsigned int m_minor;
> > bool m_is_master;
> > + std::string m_device;
>
> This looks like an extra change.
Oops, indeed.
Should I submit a v2 of the whole series to address your other concerns,
or do you plan to already merge some of the patches ? In the latter
case, feel free to give this small issue when applying :-) (along with
s/get_minor/dev_minor/ in the commit message as pointed our by Sergei).
--
Regards,
Laurent Pinchart
