RE: [PATCH v2] phy: renesas: rcar-gen3-usb2: fix SError happen if DEBUG_SHIRQ is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Vinod Koul, Sent: Friday, July 17, 2020 5:46 PM
<snip>
> > > >  static int rcar_gen3_phy_usb2_init(struct phy *p)
> > > >  {
> > > >  	struct rcar_gen3_phy *rphy = phy_get_drvdata(p);
> > > >  	struct rcar_gen3_chan *channel = rphy->ch;
> > > >  	void __iomem *usb2_base = channel->base;
> > > >  	u32 val;
> > > > +	int ret;
> > > > +
> > > > +	if (!rcar_gen3_is_any_rphy_initialized(channel) && channel->irq >= 0) {
> > > > +		INIT_WORK(&channel->work, rcar_gen3_phy_usb2_work);
> > > > +		ret = request_irq(channel->irq, rcar_gen3_phy_usb2_irq,
> > > > +				  IRQF_SHARED, dev_name(channel->dev), channel);
> > > > +		if (ret < 0)
> > > > +			dev_err(channel->dev, "No irq handler (%d)\n",
> > > > +				channel->irq);
> > >
> > > This could be in a single line :)
> >
> > Yes. We could be 80 over characters in a line now :)
> > I'll fix it.
> >
> > > Should we continue on error here?
> >
> > Hmm, maybe it's better if the request_irq() failed because
> > it can avoid unexpected behaviors. But, original code continued on error.
> > In this case, should I make a separated incremental patch to exit on error?
> 
> Yes that would be better :), Always, a patch per change

Thank you for the reply. I got it :)

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux