Hi Laurent, On Wed, Jul 15, 2020 at 02:45:35AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Tue, Jul 14, 2020 at 04:28:55PM +0200, Jacopo Mondi wrote: > > Document the 'remote-endpoint' property and add it to the list of required > > endpoint properties in imx219 and ov8856 dt-schema binding files. > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++ > > Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml > > index dfc4d29a4f04..0251e15fe0a7 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml > > +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml > > @@ -71,8 +71,13 @@ properties: > > description: > > Allowed data bus frequencies. > > > > + remote-endpoint: > > + description: |- > > + phandle to the video receiver input port > > + > > required: > > - link-frequencies > > + - remote-endpoint > > > > required: > > - compatible > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > index 1956b2a32bf4..c1f363bb5aee 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > @@ -84,9 +84,14 @@ properties: > > Allowed data bus frequencies. 360000000, 180000000 Hz or both > > are supported by the driver. > > > > + remote-endpoint: > > + description: |- > > + phandle to the video receiver input port > > + > > Extraneous blank line ? > Yes indeed. I'll fix and resend with your comments taken in (this and the one in the previous patch). Rob, Hans: Should this go in through the media tree or through rob ? Thanks j > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > > required: > > - link-frequencies > > + - remote-endpoint > > > > required: > > - endpoint > > -- > Regards, > > Laurent Pinchart
