Hi Prabhakar, On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx> > > Add support for RZ/G2H (R8A774E1) SoC IPMMUs. > > Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -751,6 +751,7 @@ static const struct soc_device_attribute soc_rcar_gen3[] = { > static const struct soc_device_attribute soc_rcar_gen3_whitelist[] = { > { .soc_id = "r8a774b1", }, > { .soc_id = "r8a774c0", }, > + { .soc_id = "r8a774e1", }, Adding an entry to soc_rcar_gen3_whitelist[] doesn't do anything, unless you also add the same entry to soc_rcar_gen3[]. > { .soc_id = "r8a7795", .revision = "ES3.*" }, > { .soc_id = "r8a77961", }, > { .soc_id = "r8a77965", }, > @@ -963,6 +964,9 @@ static const struct of_device_id ipmmu_of_ids[] = { > }, { > .compatible = "renesas,ipmmu-r8a774c0", > .data = &ipmmu_features_rcar_gen3, > + }, { > + .compatible = "renesas,ipmmu-r8a774e1", > + .data = &ipmmu_features_rcar_gen3, > }, { > .compatible = "renesas,ipmmu-r8a7795", > .data = &ipmmu_features_rcar_gen3, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds