Hi Niklas,
On Mon, Jul 13, 2020 at 9:24 AM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> On 2020-07-07 11:59:12 +0200, Geert Uytterhoeven wrote:
> > On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund
> > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > > When adding the adv7180 device node the ports node was misspelled as
> > > port, fix this.
> > >
> > > Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input")
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm/boot/dts/r8a7793-gose.dts
> > > +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> > > @@ -336,7 +336,7 @@ composite-in@20 {
> > > reg = <0x20>;
> > > remote = <&vin1>;
> > >
> > > - port {
> > > + ports {
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > >
> >
> > Does this have any run-time impact, or dependencies?
>
> No run-time impact.
OK.
> > Don't we need the same fix for the other boards?
>
> The only other board we have that uses the same compatible string
> (adi,adv7180cp) is Draak and there the ports node is already correctly
> named.
Ah, I missed Gose is using "adi,adv7180cp", while Lager, Koelsch, Porter,
Alt, and Silk are using "adi,adv7180".
Next question: why the difference? Gose and Koelsch should be identical
w.r.t. these interfaces. In fact all boards listed above are using
ADV7180WBCP32Z, and seem to use similar wiring.
What's happening?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
