On 7/2/20 1:03 PM, Geert Uytterhoeven wrote:
> Hi Tony,
>
> On Thu, Jul 2, 2020 at 9:35 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>> * Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> [200702 14:50]:
>>> On Sun, May 24, 2020 at 7:11 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>>>> any special reason for this change ? It is not really explained in the
>>>> commit description.
>>>
>>> Indeed. Why this change?
>>
>> For a kernel console, we want it to work for important oopses
>> etc without trying to enable DMA or power on regulators for example.
>
> [...]
>
> Thanks for the explanation about irqsafe consoles!
> I think I cannot disagree with that ;-)
>
> Sorry for being a bit unclear, but my question (and I guess Günter's
> question, too) was about this particular change:
>
> static inline void uart_port_spin_lock_init(struct uart_port *port)
> {
> - if (uart_console_enabled(port))
> + if (uart_console(port))
>
> This change seems to be completely unrelated, is not explained in the
> commit description, and is the cause of the regression we're seeing.
>
Yes, that was my question as well. I still fail to understand what exactly
the explanation has to do with the problem. The same happened before,
so I concluded that I must be completely clueless, and gave up asking.
Guenter
