Hi Sudeep, > From: Sudeep Holla, Sent: Monday, June 29, 2020 11:33 PM > > (This patch never made it to my inbox, may be due to ALKML issues on that day) > > On Fri, Jun 19, 2020 at 08:29:02PM +0900, Yoshihiro Shimoda wrote: > > Call pm_set_suspend_via_firmware() in .begin() of psci_suspend_ops > > to use pm_suspend_via_firmware() on PSCI environment. > > > > I don't have issues with this change as such, but I need to understand > how and why this is used. I will comment on that separately. I thought MMC driver could use this API to detect whether the firmware was suspending or not. However, Ulf said this was not a good way because all implementation of PSCI will not turn the power off while system suspend [1]. Also, as you and Mark said on other email thread [2], the current PSCI specification cannot inform system suspend state to OS (Linux). So, I think I should recall this patch because this cannot get expected information. [1] https://lore.kernel.org/linux-renesas-soc/CAPDyKFq-dEPaU094hrk2xg18VpJAsbnf8enieFmcMhKiB1bW1A@xxxxxxxxxxxxxx/ https://lore.kernel.org/linux-renesas-soc/CAMuHMdXh1Hh6H35Mp8hBJBykUucRNwxTmW+U9SHM+xhrcwasDA@xxxxxxxxxxxxxx/T/#m442a2ce972cfdb3ff33637c120c8d096e4d07af8 Best regards, Yoshihiro Shimoda > -- > Regards, > Sudeep
