Hi Geert, Thanks for your work. On 2020-06-19 17:15:41 +0200, Geert Uytterhoeven wrote: > - Document missing "#thermal-sensor-cells", > - Factor out common required properties, > - "interrupts", "clocks", and "power-domains" are required on R-Mobile > APE6, too, > - Invert logic to simplify descriptions, > - Add "additionalProperties: false". > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> > --- > .../bindings/thermal/rcar-thermal.yaml | 53 ++++++++++++------- > 1 file changed, 34 insertions(+), 19 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml > index 0994693d240f9ff4..88787b98992fe7c9 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml > @@ -59,25 +59,40 @@ properties: > resets: > maxItems: 1 > > -if: > - properties: > - compatible: > - contains: > - enum: > - - renesas,thermal-r8a73a4 # R-Mobile APE6 > - - renesas,thermal-r8a7779 # R-Car H1 > -then: > - required: > - - compatible > - - reg > -else: > - required: > - - compatible > - - reg > - - interrupts > - - clocks > - - power-domains > - - resets > + '#thermal-sensor-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + > +allOf: > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - renesas,thermal-r8a73a4 # R-Mobile APE6 > + - renesas,thermal-r8a7779 # R-Car H1 > + then: > + required: > + - resets > + - '#thermal-sensor-cells' > + > + - if: > + not: > + properties: > + compatible: > + contains: > + const: renesas,thermal-r8a7779 # R-Car H1 > + then: > + required: > + - interrupts > + - clocks > + - power-domains > + > +additionalProperties: false > > examples: > # Example (non interrupt support) > -- > 2.17.1 > -- Regards, Niklas Söderlund
