Hello! > From: Sergei Shtylyov, Sent: Thursday, June 25, 2020 5:58 PM > > Hello! > > On 25.06.2020 5:56, Yoshihiro Shimoda wrote: > > > From: Dien Pham <dien.pham.ry@xxxxxxxxxxx> > > > > As description for DIV_ROUND_CLOSEST in file include/linux/kernel.h. > > "Result is undefined for negative divisors if the dividend variable > > type is unsigned and for negative dividends if the divisor variable > > type is unsigned." > > > > In current code, the FIXPT_DIV uses DIV_ROUND_CLOSEST but has not > > checked sign of divisor before using. It makes undefined temperature > > value in case the value is negative. > > > > This patch fixes to satisfy DIV_ROUND_CLOSEST description > > and fix bug too. Note that the variable name "reg" is not good > > because it should be the same type as rcar_gen3_thermal_read(). > > However, there is better to rename it in a further patch as > > It's better. Thank you for your review! I'll fix it. Best regards, Yoshihiro Shimoda
