Hi Kieran, On 2020-06-22 10:53:12 +0100, Kieran Bingham wrote: > Hi Jacopo, > > On 15/06/2020 13:19, Jacopo Mondi wrote: > > The M3-W SoC has been renamed to r8a77960, adjust the board.sh script to > > identify it correctly. > > > > We probably don't need to keep backwards compatibility indeed ... If the cost is low, as in this case I think backwards compatibility is nice. More often then not do I bisect over large ranges and then it's nice that things like this "just work" ;-) > > > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> > > --- > > scripts/boards.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/boards.sh b/scripts/boards.sh > > index 0ec2981..2069494 100644 > > --- a/scripts/boards.sh > > +++ b/scripts/boards.sh > > @@ -13,7 +13,7 @@ case $info in > > vins="0 1 2 3 4 5 6 7" > > csis="20 40 41" > > ;; > > - "Renesas Salvator-X board based on r8a7796" | \ > > + "Renesas Salvator-X board based on r8a77960" | \ > > "Renesas Salvator-X 2nd version board based on r8a77965") > > But I wonder if this script should use more 'wildcard' matching. > It does seem awkward to match generically in some cases though, so > nothing wrong with keeping things explicit for now. > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > But now I've written that I see these patches are already integrated ... > never mind. > -- > Kieran > > > > gen="gen3" > > vins="0 1 2 3 4 5 6 7" > > > -- Regards, Niklas Söderlund
