Hi Alex,
On 02/04/2020 19:35, Alex Riesen wrote:
> As the driver has some support for the audio interface of the device,
> the bindings file should mention it.
>
> Signed-off-by: Alexander Riesen <alexander.riesen@xxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> --
>
> v3: remove optionality off MCLK clock cell to ensure the description
> matches the hardware no matter if the line is connected.
> Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/i2c/adv748x.txt | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> index 4f91686e54a6..50a753189b81 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> @@ -2,7 +2,9 @@
>
> The ADV7481 and ADV7482 are multi format video decoders with an integrated
> HDMI receiver. They can output CSI-2 on two independent outputs TXA and TXB
> -from three input sources HDMI, analog and TTL.
> +from three input sources HDMI, analog and TTL. There is also support for an
> +I2S-compatible interface connected to the audio processor of the HDMI decoder.
> +The interface has TDM capability (8 slots, 32 bits, left or right justified).
>
> Required Properties:
>
> @@ -16,6 +18,8 @@ Required Properties:
> slave device on the I2C bus. The main address is mandatory, others are
> optional and remain at default values if not specified.
>
> + - #clock-cells: must be <0>
> +
> Optional Properties:
>
> - interrupt-names: Should specify the interrupts as "intrq1", "intrq2" and/or
> @@ -47,6 +51,7 @@ are numbered as follows.
> TTL sink 9
> TXA source 10
> TXB source 11
> + I2S source 12
>
> The digital output port nodes, when present, shall contain at least one
> endpoint. Each of those endpoints shall contain the data-lanes property as
> @@ -72,6 +77,7 @@ Example:
>
> #address-cells = <1>;
> #size-cells = <0>;
> + #clock-cells = <0>;
>
> interrupt-parent = <&gpio6>;
> interrupt-names = "intrq1", "intrq2";
> @@ -113,4 +119,12 @@ Example:
> remote-endpoint = <&csi20_in>;
> };
> };
> +
> + port@c {
> + reg = <12>;
> +
> + adv7482_i2s: endpoint {
> + remote-endpoint = <&i2s_in>;
> + };
> + };
> };
>
--
Regards
--
Kieran
