Hi Wolfram, Uli, On Sun, Jun 14, 2020 at 11:31 AM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > On Wed, Jun 10, 2020 at 09:33:11PM +0200, Ulrich Hecht wrote: > > Implements atomic transfers to fix reboot/shutdown on r8a7790 Lager and > > similar boards. > > > > Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx> > > Thanks, Uli! Works fine here. Really nice to finally being able to > reboot now without WARNings. > > - pm_runtime_get_sync(pd->dev); > > + if (!pd->atomic_xfer) > > + pm_runtime_get_sync(pd->dev); > > This was a small surprise to me. I assume RPM is disabled that late? > But can we be sure the clock is on, then? And the power domain, as this is for i2c-sh_mobile.c. On SH/R-Mobile SoCs, the i2c block is part of a power area. Most are part of A3SP (which is never really disabled due to being shared with other devices), or C5 (always-on), but i2c0 on R-Mobile A1 is part of A4R, which is usually suspended. Uli: can you check if atomic transfers work with the touchscreen or codec on Armadillo-800-EVA? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds