Hi Prabhakar, On Wed, May 27, 2020 at 10:24 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > Enable support for HSUB, USB2.0 and xhci on iWave RZ/G1H carrier board. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > @@ -88,6 +114,21 @@ > function = "sdhi2"; > power-source = <1800>; > }; > + > + usb0_pins: usb0 { > + groups = "usb0"; > + function = "usb0"; > + }; > + > + usb1_pins: usb1 { > + groups = "usb1"; > + function = "usb1"; > + }; > + > + usb2_pins: usb2 { > + groups = "usb2"; > + function = "usb2"; > + }; > }; Looking at the schematics[*], I'm having a hard time making some sense out of this. GP5_21 (USB1_OVC) seems to be GPIO_AVB_SEL, and GP5_22 (USB2_PWEN) is GPIO_SD1_LED? I must be missing something? [*] *RZ_G1H_SOM.pdf, *RZ_G1M_G1N_G1H_Q7 carrierBoard.pdf Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds