On Fri, May 22, 2020 at 4:01 PM Anders Roxell <anders.roxell@xxxxxxxxxx> wrote: > It's soc@xxxxxxxxxx that this needs to go to with an explicit request for them to apply. Please resend so it gets in their Patchwork. > An allmodconfig kernel makes CONFIG_VEXPRESS_CONFIG a module and > CONFIG_POWER_RESET_VEXPRESS builtin. That makes us see this build > error: > > aarch64-linux-gnu-ld: drivers/power/reset/vexpress-poweroff.o: in function `vexpress_reset_probe': > ../drivers/power/reset/vexpress-poweroff.c:119: undefined reference to `devm_regmap_init_vexpress_config' > ../drivers/power/reset/vexpress-poweroff.c:119:(.text+0x48c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > `devm_regmap_init_vexpress_config' > make[1]: *** [/srv/src/kernel/next/Makefile:1126: vmlinux] Error 1 > > Rework so that POWER_RESET_VEXPRESS depends on 'VEXPRESS_CONFIG=y'. > > Fixes: d06cfe3f123c ("bus: vexpress-config: Merge vexpress-syscfg into vexpress-config") > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx> > --- > drivers/power/reset/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index 4dfac618b942..f07b982c8dff 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -191,7 +191,7 @@ config POWER_RESET_VERSATILE > config POWER_RESET_VEXPRESS > bool "ARM Versatile Express power-off and reset driver" > depends on ARM || ARM64 > - depends on VEXPRESS_CONFIG > + depends on VEXPRESS_CONFIG=y > help > Power off and reset support for the ARM Ltd. Versatile > Express boards. > -- > 2.26.2 >