On 14/05/2020 17:25, Niklas Söderlund wrote: > Moving the ctemp variable out of the private data structure made it > possible to clean up rcar_thermal_update_temp(). Initialize the local > ctemp to the error code to return if the reading fails and just return > it at the end of the function. > > It's OK to change the datatype of old, new and ctemp to int as all > values are ANDed with CTEMP (0x3f) before being stored. While at it > change the datatype of the loop variable 'i' to to unsigned int. > > Suggested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- Applied, thanks -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
