On Wed, May 20, 2020 at 3:40 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Wed, May 20, 2020 at 3:38 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Wed, May 20, 2020 at 2:14 PM Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxx> wrote: > > > On Mon, May 11, 2020 at 04:52:51PM +0200, Geert Uytterhoeven wrote: > > ... > > > > Sorry for late reply, recently noticed this nice idea. > > > The comment I have is, please, can we reuse bitmap parse algorithm and syntax? > > > We have too many different formats and parsers in the kernel and bitmap's one > > > seems suitable here. > > > > Thank you, I wasn't aware of that. > > > > Which one do you mean? The documentation seems to be confusing, > > and incomplete. > > My first guess was bitmap_parse(), but that one assumes hex values? > > And given it processes the unsigned long bitmap in u32 chunks, I guess > > it doesn't work as expected on big-endian 64-bit? > > > > bitmap_parselist() looks more suitable, and the format seems to be > > compatible with what's currently used, so it won't change ABI. What ABI? We didn't have a release with it, right? So, we are quite flexible for few more weeks to amend it. > > Is that the one you propose? > > Yes, sorry for the confusion. > > > > (Despite other small clean ups, like strstrip() use) > > > > Aka strim()? There are too many of them, to know all of them by heart ;-) > > The difference between them is __must_check flag. But yes. -- With Best Regards, Andy Shevchenko
