Hi Niklas,
Thanks for your patch!
On Fri, May 15, 2020 at 3:56 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> The function rcar_gen3_thermal_calc_coefs() takes an argument called
> 'thcode' which shadows the static global 'thcode' variable. This is not
> harmful but bad for readability and is harmful for planed changes to the
planned
> driver. The THCODE values should be read from hardware fuses if they are
> available and only fallback to the global 'thcode' variable if they are
> not fused.
>
> Rename the global 'thcode' variable to 'thcodes' to avoid shadowing the
> symbol in functions that takes it as an argument.
take
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
