On Thu, May 07, 2020 at 08:44:12AM +0200, Johan Hovold wrote:
> On Thu, May 07, 2020 at 12:27:53AM +0530, Naresh Kamboju wrote:
> > On Tue, 29 Nov 2016 at 00:00, Johan Hovold <johan@xxxxxxxxxx> wrote:
> > >
> > > Make sure to deregister and free any fixed-link PHY registered using
> > > of_phy_register_fixed_link() on probe errors and on driver unbind.
> > >
> > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links")
> > > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > > ---
> > > drivers/net/ethernet/marvell/mvneta.c | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> > > index 0c0a45af950f..707bc4680b9b 100644
> > > --- a/drivers/net/ethernet/marvell/mvneta.c
> > > +++ b/drivers/net/ethernet/marvell/mvneta.c
> > > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev)
> > > clk_disable_unprepare(pp->clk);
> > > err_put_phy_node:
> > > of_node_put(phy_node);
> > > + if (of_phy_is_fixed_link(dn))
> > > + of_phy_deregister_fixed_link(dn);
> >
> > While building kernel Image for arm architecture on stable-rc 4.4 branch
> > the following build error found.
> >
> > drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit
> > declaration of function 'of_phy_deregister_fixed_link'; did you mean
> > 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration]
> > | of_phy_deregister_fixed_link(dn);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | of_phy_register_fixed_link
> >
> > ref:
> > https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729
>
> Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link
> PHYs") needs to be backported as well for these.
>
> Original series can be found here:
>
> https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@xxxxxxxxxx
Ah, thanks for that, I thought I dropped all of the ones that caused
build errors, but missed the above one. I'll go take the whole series
instead.
greg k-h
