在 2020/4/17 17:31, Geert Uytterhoeven 写道:
Hi Jason,
On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@xxxxxxxxxx> wrote:
Fix the following gcc warning:
drivers/pinctrl/pinctrl-rza1.c:401:35: warning: ‘rza1l_swio_pins’
defined but not used [-Wunused-const-variable=]
static const struct rza1_swio_pin rza1l_swio_pins[] = {
^~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
Thanks for your patch!
--- a/drivers/pinctrl/pinctrl-rza1.c
+++ b/drivers/pinctrl/pinctrl-rza1.c
@@ -398,15 +398,6 @@ static const struct rza1_bidir_pin rza1l_bidir_pins_p9[] = {
{ .pin = 5, .func = 3 },
};
-static const struct rza1_swio_pin rza1l_swio_pins[] = {
- { .port = 2, .pin = 8, .func = 2, .input = 0 },
- { .port = 5, .pin = 6, .func = 3, .input = 0 },
- { .port = 6, .pin = 6, .func = 3, .input = 0 },
- { .port = 6, .pin = 10, .func = 3, .input = 0 },
- { .port = 7, .pin = 10, .func = 2, .input = 0 },
- { .port = 8, .pin = 2, .func = 3, .input = 0 },
-};
-
static const struct rza1_bidir_entry rza1l_bidir_entries[RZA1_NPORTS] = {
[1] = { ARRAY_SIZE(rza1l_bidir_pins_p1), rza1l_bidir_pins_p1 },
[3] = { ARRAY_SIZE(rza1l_bidir_pins_p3), rza1l_bidir_pins_p3 },
rza1l_swio_pins[] is unused because rza1l_swio_entries[] refers to the
wrong array. So I'd rather see a patch to fix that instead.
Thanks for the explanation, I will send a new one.
Thanks!
Gr{oetje,eeting}s,
Geert
