Laurent Pinchart, Thu, Mar 19, 2020 19:06:14 +0100: > On Thu, Mar 19, 2020 at 06:41:53PM +0100, Alex Riesen wrote: > > #define io_read(s, r) adv748x_read(s, ADV748X_PAGE_IO, r) > > #define io_write(s, r, v) adv748x_write(s, ADV748X_PAGE_IO, r, v) > > -#define io_clrset(s, r, m, v) io_write(s, r, (io_read(s, r) & ~(m)) | (v)) > > +#define io_clrset(s, r, m, v) adv748x_update_bits(s, ADV748X_PAGE_IO, r, m, v) > > +#define io_update(s, r, m, v) adv748x_update_bits(s, ADV748X_PAGE_IO, r, m, v) > > Those two are identical. Do we need both ? I would standardize on either > *_update or *_clrset for all the functions here. Apart from that, Shame on me. *_clrset that is (it was there before me). > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Thanks! Regards, Alex
