Hi Geert, On Wed, Mar 18, 2020 at 6:55 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Magnus, > > On Wed, Mar 18, 2020 at 10:35 AM Magnus Damm <magnus.damm@xxxxxxxxx> wrote: > > From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> > > > > This patch adds support for a couple of LEDs on Salvator-X and XS boards. > > Thanks for your patch! Thanks. Not exactly rocket science! > > I've verified that LED4, LED5 and LED6 work by exporting GPIOs for GP6_11, > > GP6_12 and GP6_13 on the board on port 9011. This patch has not yet been > > tested though. Also to make matters slightly more complicated, even if LEDs > > might work with this patch as-is, the code in this patch is most likely not > > suitable for upstream consumption. This since SW20, SW21 and SW22 are also > > using the same GPIOs as the LEDs. > > Indeed. I think we should add kernel support for sharing GPIOs this way, > before we can describe the LEDs in DT. Else we'll introduce a regression, > depending on which driver is bound first. Totally agree. > > Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> > > As this matches with an old local patch of mine: > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > However, I'm not gonna apply it, without a fix for the sharing issue. Sure, makes sense! Thanks, / magnus
