Hi Wolfram, Thanks for your work. On 2020-03-12 14:45:07 +0100, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > to_spi_device() already checks 'dev'. No need to do it before calling > it. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > > Found while fiddling with bus_find_device_by_acpi_dev() in the I2C > subsystem. > > drivers/spi/spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 755221bc3745..75978b6c5834 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -4034,7 +4034,7 @@ static struct spi_device *acpi_spi_find_device_by_adev(struct acpi_device *adev) > struct device *dev; > > dev = bus_find_device_by_acpi_dev(&spi_bus_type, adev); > - return dev ? to_spi_device(dev) : NULL; > + return to_spi_device(dev); > } > > static int acpi_spi_notify(struct notifier_block *nb, unsigned long value, > -- > 2.20.1 > -- Regards, Niklas Söderlund
