On 3/6/20 6:28 AM, Laurent Pinchart wrote: > Hi Randy, > > On Thu, Mar 05, 2020 at 07:17:49PM -0800, Randy Dunlap wrote: >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> >> DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig >> symbols do not depend on DRM_RCAR_DU, the menu presentation is >> broken for these and following non-R-Car Kconfig symbols. >> >> Is it safe/appropriate to make all of these symbols depend on >> DRM_RCAR_DU? It make the kconfig menu presentation much cleaner. > > As those drivers are useless without DRM_RCAR_DU, I'm fine with this > change. It however prevents test-compiling those drivers when > DRM_RCAR_DU is disabled, but I see little reason to do so anyway, I > expect compile tests to aim for as large coverage as possible, and they > should thus enable DRM_RCAR_DU. > > Would you like to submit a new version without this question, and > possibly addressing Geert's concern if you think it's appropriate, or > should I do so when applying ? > >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >> Cc: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx >> Cc: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx> >> Cc: Dave Airlie <airlied@xxxxxxxx> >> --- >> drivers/gpu/drm/rcar-du/Kconfig | 3 +++ >> 1 file changed, 3 insertions(+) >> >> --- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig >> +++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig >> @@ -24,6 +24,7 @@ config DRM_RCAR_CMM >> config DRM_RCAR_DW_HDMI >> tristate "R-Car DU Gen3 HDMI Encoder Support" >> depends on DRM && OF >> + depends on DRM_RCAR_DU >> select DRM_DW_HDMI >> help >> Enable support for R-Car Gen3 internal HDMI encoder. >> @@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI >> config DRM_RCAR_LVDS >> tristate "R-Car DU LVDS Encoder Support" >> depends on DRM && DRM_BRIDGE && OF >> + depends on DRM_RCAR_DU >> select DRM_PANEL >> select OF_FLATTREE >> select OF_OVERLAY >> @@ -47,4 +49,5 @@ config DRM_RCAR_VSP >> >> config DRM_RCAR_WRITEBACK >> bool >> + depends on DRM_RCAR_DU >> default y if ARM64 > > Is this one needed ? The symbol should not be shown in the kconfig menu > as it has no text. Hi Laurent, I tried the patch without that line as my first attempt and there was still a problem with the menu, so I will resubmit the patch using a block as Geert suggested. thanks. -- ~Randy
