Hi Wolfram, Thanks for your patch! On Thu, Feb 20, 2020 at 6:26 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > - don't prefix the device if %pOF is provided. That information is > enough. While that information is sufficient to identify the device, using a mix of dev_*() and pr_*("... %pOF...") makes it harder to grep for relevant information in the kernel log. Hence I'm not convinced this is an improvement. > - move the prefix to pr_fmt > - change prefix from "of_i2c" to "i2c_of" because the code was moved > out of the of-domain long ago > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Nevertheless: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds