On Thu, Feb 13, 2020 at 9:47 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Gilad, > > On Thu, Feb 13, 2020 at 7:46 AM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > > On Tuesday, February 11, 2020, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote: > >> This series contains several fixes, cleanups, and other improvements for > >> the ARM TrustZone CryptoCell driver. > > > > Thank you so much for doing this Geert. > > > > The whole series looks wonderful. It does not only makes the driver better, it has made me a better programmer - I'm not ashamed to say I've learned some new things about the kernel API from this series... > > > > I am currently out of the office until mid next week and away from my testing lab. > > > > I'd like to delay formal ACK until I return and run a regression test suite using some of the newer revisions of the hardware which the driver also support, just in case, although I don't forsee any issues. I hope that is ok. > > Should be OK, we're only at rc1. > I'm looking forward to the test results on newer hardware revision/ The smoke test on the most recent HW looks OK, I've submitted the changes to a longer regression test suite on multiple HW and it is running. I hope to have a final result and an ACK by tomorrow. Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker values of β will give rise to dom!