On Thu, Feb 6, 2020 at 4:45 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Gilad, > > On Sun, Feb 2, 2020 at 5:19 PM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote: > > Remove the auth tag size from cryptlen before mapping the destination > > in out-of-place AEAD decryption thus resolving a crash with > > extended testmgr tests. > > > > Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> > > Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx # v4.19+ > > Thanks, this fixes the crash seen on R-Car H3 ES2.0 with renesas_defconfig, > CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n, and CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y > > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks again for your help. > > Remaining issues reported during boot: > 1. alg: skcipher: blocksize for xts-aes-ccree (1) doesn't match > generic impl (16) Yes, this is actually a known issue with the generic XTS implementation. See: https://lore.kernel.org/linux-crypto/VI1PR0402MB34858E4EF0ACA7CDB446FF5798CE0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > 2. alg: aead: rfc4543-gcm-aes-ccree decryption unexpectedly > succeeded on test vector "random: alen=16 plen=39 authsize=16 klen=20 > novrfy=1"; expected_error=-EBADMSG or -22, cfg="random: may_sleep > use_digest src_divs=[4.47%@+3553, 30.80%@+4065, 12.0%@+11, > 6.22%@+2999, 46.51%@alignmask+3468]" Yes, I am working on this one right now. Many thanks, Gilad