Hi Alan,
Thank you for your review!
> From: Alan Stern, Sent: Saturday, January 25, 2020 12:18 AM
<snip>
> > diff --git a/include/linux/usb/ehci_def.h b/include/linux/usb/ehci_def.h
> > index a15ce99..0ebfa74 100644
> > --- a/include/linux/usb/ehci_def.h
> > +++ b/include/linux/usb/ehci_def.h
> > @@ -150,6 +150,7 @@ struct ehci_regs {
> > #define PORT_LED_MASK (3<<14)
> > #define PORT_OWNER (1<<13) /* true: companion hc owns this port */
> > #define PORT_POWER (1<<12) /* true: has power (see PPC) */
> > +#define PORT_LS_MASK (3<<10) /* USB 1.1 device */
>
> The comment should say: /* Link status (SE0, K, or J) */
Oops. I'll fix it.
> > #define PORT_USB11(x) (((x)&(3<<10)) == (1<<10)) /* USB 1.1 device */
> > /* 11:10 for detecting lowspeed devices (reset vs release ownership) */
>
> You can remove this comment now. Since there is an actual macro for
> bits 11:10, we don't need a separate comment saying what they are.
I got it. I'll remove the "/* 11:10 for ..." comment on v4 patch.
Best regards,
Yoshihiro Shimoda
> Alan Stern
>
> > /* 9 reserved */
