Hi Sam, On Wed, Jan 15, 2020 at 10:01 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > On Wed, Jan 15, 2020 at 01:45:44PM +0100, Geert Uytterhoeven wrote: > > Convert the DT binding documentation for Sitronix ST7735R displays to DT > > schema. > > > > Add a reference to the Adafruit 1.8" LCD while at it. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > > new file mode 100644 > > index 0000000000000000..21bccc91f74255e1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > Use (GPL-2.0-only OR BSD-2-Clause) for new binding files. I used GPL-2.0-only, as this is a conversion of an existing binding file, covered by the default GPL-2.0-only of the Linux kernel source tree. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sitronix ST7735R Display Panels Device Tree Bindings > > + > > +maintainers: > > + - David Lechner <david@xxxxxxxxxxxxxx> > > + > > +description: > > + This binding is for display panels using a Sitronix ST7735R controller in > > + SPI mode. > > + > > +allOf: > > + - $ref: panel/panel-common.yaml# > > I am no binding expert so I do not know how to add it. > But the old binding described that this MUST be a child of spi. > This is missing here. > > Other panels using spi does not have it - so it is probarly OK. Yeah, I couldn't find any examples of expressing that requirement in yaml. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
