Re: [RFC][PATCH] ARM: dts: renesas: Add missing ethernet PHY reset GPIO on Gen2 reference boards

[Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>]

Hi Marek,

Thanks for your work.

On 2020-01-12 20:13:15 +0100, Marek Vasut wrote:
> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
> 
> The ethernet PHY reset GPIO was missing and the kernel was depending
> solely on the bootloader to bring the PHY out of reset. Fix this to
> get rid of the dependency on bootloader.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> NOTE: Thus far tested on R8A7791 Koelsch

I also only have a Koelsch board, but for what it's worth (for Koelsch):

Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  arch/arm/boot/dts/r8a7790-lager.dts   | 1 +
>  arch/arm/boot/dts/r8a7790-stout.dts   | 1 +
>  arch/arm/boot/dts/r8a7791-koelsch.dts | 1 +
>  arch/arm/boot/dts/r8a7791-porter.dts  | 1 +
>  arch/arm/boot/dts/r8a7793-gose.dts    | 1 +
>  arch/arm/boot/dts/r8a7794-alt.dts     | 1 +
>  arch/arm/boot/dts/r8a7794-silk.dts    | 1 +
>  7 files changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 097fd9317c6e..b88d4f4d5d9e 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -671,6 +671,7 @@ &ether {
>  
>  	phy1: ethernet-phy@1 {
>  		reg = <1>;
> +		reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>;
>  		interrupt-parent = <&irqc0>;
>  		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
> diff --git a/arch/arm/boot/dts/r8a7790-stout.dts b/arch/arm/boot/dts/r8a7790-stout.dts
> index a315ba749aa4..98dcfcbf0b70 100644
> --- a/arch/arm/boot/dts/r8a7790-stout.dts
> +++ b/arch/arm/boot/dts/r8a7790-stout.dts
> @@ -200,6 +200,7 @@ &ether {
>  
>  	phy1: ethernet-phy@1 {
>  		reg = <1>;
> +		reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
>  		interrupt-parent = <&irqc0>;
>  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 2b096d5e06fb..6619689a17d4 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -630,6 +630,7 @@ &ether {
>  
>  	phy1: ethernet-phy@1 {
>  		reg = <1>;
> +		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
>  		interrupt-parent = <&irqc0>;
>  		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
> diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts
> index f9ece7ab2010..2ba2e8e5f1c3 100644
> --- a/arch/arm/boot/dts/r8a7791-porter.dts
> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
> @@ -304,6 +304,7 @@ &ether {
>  
>  	phy1: ethernet-phy@1 {
>  		reg = <1>;
> +		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
>  		interrupt-parent = <&irqc0>;
>  		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
> index 22ca7cd1e7d2..4da82f1e1e94 100644
> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -588,6 +588,7 @@ &ether {
>  
>  	phy1: ethernet-phy@1 {
>  		reg = <1>;
> +		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
>  		interrupt-parent = <&irqc0>;
>  		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
> index f79fce74cd9c..7aa1e8ca808b 100644
> --- a/arch/arm/boot/dts/r8a7794-alt.dts
> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
> @@ -340,6 +340,7 @@ &ether {
>  
>  	phy1: ethernet-phy@1 {
>  		reg = <1>;
> +		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
>  		interrupt-parent = <&irqc0>;
>  		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
> diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts
> index 2c16ad854300..3c0ed684f4a1 100644
> --- a/arch/arm/boot/dts/r8a7794-silk.dts
> +++ b/arch/arm/boot/dts/r8a7794-silk.dts
> @@ -391,6 +391,7 @@ &ether {
>  
>  	phy1: ethernet-phy@1 {
>  		reg = <1>;
> +		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
>  		interrupt-parent = <&irqc0>;
>  		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
> -- 
> 2.24.1
> 

-- 
Regards,
Niklas Söderlund