On 12/18/2019 03:49 PM, Biju Das wrote:
>> Subject: Re: [PATCH] clock: renesas: cpg-mssr: Fix the typo
>>
>> On 18.12.2019 14:09, Biju Das wrote:
>>
>>> This patch fixes the typo %s/r8a774a1/r8a774b1/.
>>>
>>> Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1
>>
>> SHA1 should have at least 12 digits.
>>
> Ok will do.
>
>>> binding")
>>
>> And never break up the tag lines please.
>
> Do you mean , do the changes like below and ignore check patch warnings?
checkpatch.pl doesn't complain to me, even about short SHA1...
> Is it acceptable to everyone?
I remember e.g. Dave Miller complaining about breaking up the "Fixes:" tag --
I think it breaks patchwork. Looking at Documentation/process/submitting-patches.rst,
this format is even codified...
> Fixes: 10003938a0c64c2f0d89 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 binding")
>
>>> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
>> [...]
MBR, Sergei
