Hi Jacopo, On Thu, Dec 12, 2019, Jacopo Mondi wrote: > > - dev_info(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n", > > + dev_dbg(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n", > > chip->label, chip->ngpio); > > Please align this line to the open ( ... Sorry to bother for such minor thing. Fair point! I'll fix and resend. > There are other dev_info which might show up frequently, I'm looking at line > 1054 in example. I think it's fine as they show the actually enabled groups... Ya, I'm OK that. When checking someone's logs, I can see if they actually enabled the pins or not. I was just annoyed by all the text about registering the ports....that comes from the .dtsi that no one every changes.....and I was scrolling though trying to find my print debug messages for another driver I was debugging :o > Anway, minor alignement issue apart > Acked-by: Jacopo Mondi <jacopo@xxxxxxxxxx> Thank you. I'll resend with your ACK Chris
