Re: [PATCH/RFC] arm64: dts: renesas: Rename r8a7796* to r8a77960*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eugeniu,

On Wed, Dec 11, 2019 at 8:52 PM Eugeniu Rosca <erosca@xxxxxxxxxxxxxx> wrote:
> On Wed, Dec 11, 2019 at 02:13:11PM +0100, Geert Uytterhoeven wrote:
> > Disadvantages:
> >   - The DTB files are renamed.
>
> This reminded me of a past contribution [*], where, based on feedback
> from Laurent and Simon, the decision was to avoid DTS renaming. Does
> this series mean that one day, given enough time and resources, we
> might also eliminate the "r8a779[5-6]" and "(h3|m3|m3n)" redundancy in
> the naming scheme of the ULCB DTS? (not that it bothers me much)

Thanks for reminding me!

At that time, the rename was considered too intrusive, compared to the
slim benefit.

However, if we're renaming the files anyway, and thus causing a
(temporary) inconvenience for the user, I think this is a good moment
to get rid of the "(h3|m3|m3n)" redundancy in the DTS naming scheme
(unfortunately we cannot do that for the "renesas,(h3|m3|m3n)ulcb"
 compatible values).

Hence for R-Car H3, I will move forward the rename of the DTS files, so
all renames happen in the same kernel release time frame.

Regarding the R-Car V3HSK and V3MSK boards, dropping the "v3m" resp.
"v3h" from r8a77970-v3msk.dts resp. r8a77980-v3hsk.dts is IMHO
different: the boards are not called "sk", and are far from identical,
unlike "ulcb" and "salvator-x(s)".
Renesas has lots of "sk", "rsk", and "evm" boards. Let's hope they don't
plan any unrelated "ulcb" boards...

> PS: [Thinking out loud] Need to get prepared for using two versions of
> U-Boot scripts when switching between BSP and vanilla kernels on the
> r8a77960 targets. This will definitely add a tiny bit of overhead, but
> nevertheless it looks like an investment to me, the one which users
> will not regret (on the contrary, will be happy about) in some years
> from now.

I'm fully aware of that inconvenience.

> Reviewed-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>

Thank you!

> [*] https://patchwork.kernel.org/patch/10555955/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux