On Mon, Nov 11, 2019 at 07:02:30PM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Mon, Nov 11, 2019 at 03:00:55PM +0100, Jacopo Mondi wrote:
> > The example provided by the video-interface.txt file uses compatible
> > values for drivers which are have been removed a long time ago. To avoid
> > generating confusion, replace the existing example with a new one using
> > upstream maintained and more modern devices.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > ---
> >
> > Re-proposing the example update, taking into account Niklas' comments about
> > removing most of the commits there.
> >
> > Laurent suggested to move the example to json-schema, but being this file mostly
> > used as reference for the common video properties description, I'm not sure
> > bindings in yaml format make sense here.
>
> I think the proposal makes sense as such, but this patch is just updating
> the example. The two seem unrelated.
Agreed.
Moving to schema does make sense. Probably want to split device and
endpoint properties to 2 files.
Then you have something like this in the users:
endpoint:
allOf:
- $ref: video-interfaces-endpoints.yaml#
properties:
bus-width:
# Only define what's specific to this device
enum: [ 8, 16 ]
default: 8
You could define more of the graph structure, but I figure we'll have a
graph schema at some point. It hasn't been high on my priority list
because the dtc checks for graphs are pretty good.
Rob
