Hello!
On 11/14/2019 04:49 AM, Ulrich Hecht wrote:
> Pre-allocates buffers sufficient for the maximum supported MTU (2026) in
> order to eliminate the possibility of resource exhaustion when changing the
> MTU while the device is up.
>
> Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/renesas/ravb.h | 3 ++-
> drivers/net/ethernet/renesas/ravb_main.c | 26 +++++++++++++-----------
> 2 files changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
> index a9c89d5d8898..9f88b5db4f89 100644
> --- a/drivers/net/ethernet/renesas/ravb.h
> +++ b/drivers/net/ethernet/renesas/ravb.h
> @@ -955,6 +955,8 @@ enum RAVB_QUEUE {
> #define NUM_RX_QUEUE 2
> #define NUM_TX_QUEUE 2
>
> +#define RX_BUF_SZ (2048 - ETH_FCS_LEN + sizeof(__sum16))
That's smart but won't scale iff we decide to support e.g. Jumbo frames (the real AVB h/w
supports up to 128 KiB frames.
[...]
MBR, Sergei
