On Mon, Oct 28, 2019 at 03:07:28PM +0900, Yoshihiro Shimoda wrote: > This patch adds missing required properties of power-domains and resets. > Fortunately, no one has this device node for now, so that we don't > need to think of backward compatibility. > > Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > --- > .../devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > index 5c1903f..bad876f 100644 > --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > @@ -43,6 +43,9 @@ Required properties: > - The USB_EXTAL clock pin must be "usb_extal" > - The USB_XTAL clock pin must be "usb_xtal" > - #clock-cells: Must be 0 > +- power-domains: A phandle and symbolic PM domain specifier. > + See power/renesas,rcar-sysc.txt. > +- resets: A list of phandles and specifier pairs. > > Example (R-Car H3): > > @@ -54,4 +57,6 @@ Example (R-Car H3): > <&usb_extal>, <&usb_xtal>; > clock-names = "ehci_ohci", "hs-usb-if", "usb_extal", "usb_xtal"; > #clock-cells = <0>; > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>>; Typo in '>>' With that, Reviewed-by: Rob Herring <robh@xxxxxxxxxx>