Re: [PATCH] dt-bindings: usb: renesas: usb3-peri: convert bindings to json-schema

[Rob Herring <robh@xxxxxxxxxx>]

On Wed, Oct 23, 2019 at 05:20:16PM +0900, Yoshihiro Shimoda wrote:
> Convert Renesas USB 3.0 Peripheral controller bindings documentation
> to json-schema.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/usb/renesas,usb3-peri.txt  | 65 ---------------
>  .../devicetree/bindings/usb/renesas,usb3-peri.yaml | 92 ++++++++++++++++++++++
>  2 files changed, 92 insertions(+), 65 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/renesas,usb3-peri.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml


> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> new file mode 100644
> index 00000000..489a8cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/renesas,usb3-peri.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas USB 3.0 Peripheral controller
> +
> +maintainers:
> +  - Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    oneOf:

Don't need oneOf here.

> +      - items:
> +          - enum:
> +              - renesas,r8a774a1-usb3-peri # RZ/G2M
> +              - renesas,r8a774b1-usb3-peri # RZ/G2N
> +              - renesas,r8a774c0-usb3-peri # RZ/G2E
> +              - renesas,r8a7795-usb3-peri  # R-Car H3
> +              - renesas,r8a7796-usb3-peri  # R-Car M3-W
> +              - renesas,r8a77965-usb3-peri # R-Car M3-N
> +              - renesas,r8a77990-usb3-peri # R-Car E3
> +          - const: renesas,rcar-gen3-usb3-peri
> +
> +  reg:
> +    # Base address and length of the register for the USB 3.0 Peripheral
> +    maxItems: 1
> +
> +  interrupts:
> +    # Interrupt specifier for the USB3.0 Peripheral
> +    maxItems: 1
> +
> +  clocks:
> +    # clock phandle and specifier pair
> +    maxItems: 1
> +
> +  phys:
> +    description: phandle + phy specifier pair.

maxItems: 1

And can drop the description

> +
> +  phy-names:
> +    const: usb
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  usb-role-switch:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: |
> +      Support role switch. See usb/generic.txt.
> +
> +  companion:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      See usb/generic.txt.
> +
> +  port:
> +    description: |
> +      any connector to the data bus of this controller should be modelled
> +      using the OF graph bindings specified in bindings/graph.txt, if the
> +      "usb-role-switch" property is used.
> +
> +required:
> +  - compatible
> +  - interrupts
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/r8a774c0-cpg-mssr.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/power/r8a774c0-sysc.h>
> +
> +    usb3_peri0: usb@ee020000 {
> +        compatible = "renesas,r8a774c0-usb3-peri", "renesas,rcar-gen3-usb3-peri";
> +        reg = <0 0xee020000 0 0x400>;
> +        interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&cpg CPG_MOD 328>;
> +        companion = <&xhci0>;
> +        usb-role-switch;
> +
> +        port {
> +            usb3_role_switch: endpoint {
> +                remote-endpoint = <&hd3ss3220_ep>;
> +            };
> +        };
> +    };
> -- 
> 2.7.4
>