RE: [PATCH 3/3] clk: renesas: rcar-usb2-clock-sel: Add reset_control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

Thank you for your comments!

> From: Geert Uytterhoeven, Sent: Thursday, October 24, 2019 8:26 PM
<snip>
> > This hardware needs to deassert resets of both host and peripheral.
> > So, this patch adds reset control.
> 
> If the hardware needs it, probably you want to make CLK_RCAR_USB2_CLOCK_SEL
> select RESET_CONTROLLER?

You're correct. I'll fix it.

> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> 
> > @@ -164,6 +172,10 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev)
> >         if (IS_ERR(priv->clks[CLK_INDEX_HS_USB]))
> >                 return PTR_ERR(priv->clks[CLK_INDEX_HS_USB]);
> >
> > +       priv->rsts = devm_reset_control_array_get_optional_shared(&pdev->dev);
> 
> If the reset is really needed, you should not use the optional API.

That's true. So, I'll use devm_reset_control_array_get(&pdev->dev, true, false)

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux