On Thu, Oct 17, 2019 at 05:01:26PM +0200, Marek Vasut wrote: [...] > > Again, just handling the first N dma-ranges entries and ignoring the > > rest is not 'configure the controller correctly'. > > It's the best effort thing to do. It's well possible the next generation > of the controller will have more windows, so could accommodate the whole > list of ranges. > > Thinking about this further, this patch should be OK either way, if > there is a DT which defines more DMA ranges than the controller can > handle, handling some is better than failing outright -- a PCI which > works with a subset of memory is better than PCI that does not work at all. OK to sum it up, this patch is there to deal with u-boot adding multiple dma-ranges to DT. I still do not understand the benefit given that for DMA masks they are useless as Rob pointed out and ditto for inbound windows programming (given that AFAICS the PCI controller filters out any transaction that does not fall within its inbound windows by default so adding dma-ranges has the net effect of widening the DMA'able address space rather than limiting it). In short, what's the benefit of adding more dma-ranges regions to the DT (and consequently handling them in the kernel) ? Thanks, Lorenzo > >>> And realistically, if the address > >>> isn't valid then it's not going to make much difference anyway - in > >>> probably 99% of cases, either the transaction doesn't hit a window and > >>> the host bridge returns a completer abort, or it does hit a window, the > >>> AXI side returns DECERR or SLVERR, and the host bridge translates that > >>> into a completer abort. Consider also that many PCI IPs don't have > >>> discrete windows and just map the entirety of PCI mem space directly to > >>> the system PA space. > >> > >> And in that 1% of cases, we are OK with failure which could have been > >> easily prevented if the controller was programmed correctly ? That does > >> not look like a good thing. > > > > You don't need dma-ranges if you want to handle holes in DRAM. Use > > memblock to get this information. Then it will work if you boot using > > UEFI too. > > Do you have any further details about this ? > > > dma-ranges at the PCI bridge should be restrictions in the PCI bridge, > > not ones somewhere else in the system. > > -- > Best regards, > Marek Vasut
