Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove audio
> port node
>
> Hi Biju,
>
> On Tue, Oct 8, 2019 at 3:43 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> > > Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove
> > > audio port node On Fri, Oct 4, 2019 at 4:53 PM Biju Das
> > > <biju.das@xxxxxxxxxxxxxx> wrote:
> > > > This patch removes audio port node from SoC device tree.
> > >
> > > Standard review comment: "Why?"
>
> Bcause it fixes a dtb warning?
>
> Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0:
> node has
> a unit name, but no reg property
I also noticed this warning.
We will get this warning, if we apply the patch "[v3,2/2] arm64: dts: renesas: r8a774b1: Add Sound and Audio DMAC
device nodes" first and then this one.
If it is other way around, then there won't be any warning. That is the reason I didn't mention it in the commit message.
Regards,
Biju
> > >
> > > > Fixes: e2f04248fcd4 ("arm64: dts: renesas: r8a774a1: Add audio
> > > > support")
> > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > > > ---
> > > > V1-->V2
> > > > * New patch.
> > > > V2-->V3
> > > > * Fixed the commit message. Thanks to Fabrizio.
> > > >
> > > > This patch depend upon
> > > > https://patchwork.kernel.org/project/linux-renesas-soc/list/?serie
> > > > s=18
> > > > 2581
> > >
> > > Why the dependency?
> > > This looks like a fix for r8a774a1, too?
> >
> > Sorry, the above dependency is for the second patch.
> > "[v3,2/2] arm64: dts: renesas: r8a774b1: Add Sound and Audio DMAC
> device nodes"
>
> OK.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
